Track toolautosubmit attribute changes for declarative tools#60416
Merged
Conversation
Declarative WebMCP tools registered via the <form> element now correctly
respond to changes in the 'toolautosubmit' attribute. Previously,
modifying this attribute after the tool was registered would leave
the tool's 'autosubmit' annotation in a stale state for the inspector.
This change:
1. Updates HTMLFormMcpTool to capture the 'toolautosubmit' attribute
state at the time of registration.
2. Modified HTMLFormElement::UpdateMcpDefinitionsIfNeeded to detect
drifts between the current attribute state and the registered tool.
3. Updated HTMLFormElement::AttributeChanged to trigger a tool
re-registration when 'toolautosubmit' is added or removed.
4. Adds an inspector protocol test to verify that toggling the
attribute correctly triggers toolsRemoved/toolsAdded events with
the updated annotation.
Fixed: 509838990
Change-Id: I68b55c73478cdedafea2e266aeb86a4fa528a308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7827761
Reviewed-by: Dominic Farolino <dom@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1642180}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7827761
branch
from
3d098f2 to
0bb0c34
Compare
wpt-pr-bot
approved these changes
Jun 5, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declarative WebMCP tools registered via the <form> element now correctly
respond to changes in the 'toolautosubmit' attribute. Previously,
modifying this attribute after the tool was registered would leave
the tool's 'autosubmit' annotation in a stale state for the inspector.
This change:
state at the time of registration.
drifts between the current attribute state and the registered tool.
re-registration when 'toolautosubmit' is added or removed.
attribute correctly triggers toolsRemoved/toolsAdded events with
the updated annotation.
Fixed: 509838990
Change-Id: I68b55c73478cdedafea2e266aeb86a4fa528a308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7827761
Reviewed-by: Dominic Farolino <dom@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1642180}